Routine for RS232

[JEliecer]

I need your help.

I have a RS232 routine, but when I send a data by the RS232 to a PIC, the program is Stopped.

This is my code:

#include<18f448.h>
#include<stdlib.h>
#use delay(clock=10000000, RESTART_WDT)
#use RS232(BAUD=9600, BITS=8, PARITY=N, XMIT=PIN_C6, RCV=PIN_C7, RESTART_WDT)
#byte PORTC=0xf82
#include<math.h>
byte year,mes,dow,m_dia,hora,min,seg,sig;
char UNO,DOS,TRES,RAEY,MOY,cmd,x;
int t,i;
char c[];
#include<RTCDS12C887.C>// This is a library for a Real time clock
#include<DRIVERLCD.C>

#use fast_io(B)
#use fast_io(C)
#use fast_io(D)
#use fast_io(E)

#int_rda
serial_recibido()
{
lcd_enviar(LCD_COMANDO,LCD_CURSOR_BLINK);
do
{
c[i]=getc(); // Get a char from the PC
delay_ms(10);
i+=1;
}
while (c[i]!=0);
lcd_putc("\f"); // Display it on the LCD
lcd_putc(c); // Display it on the LCD
delay_ms(8000);
lcd_enviar(LCD_COMANDO,LCD_DISPLAY_OFF);
lcd_enviar(LCD_COMANDO,LCD_DISPLAY_ON);
disable_interrupts(global);
disable_interrupts(int_rda);
return;
}


void main()
{
i=0;
rtc_inicio();
lcd_init();
restart_wdt();
set_tris_c(191);
while(1)
{
restart_wdt();
enable_interrupts(global);
enable_interrupts(int_rda);
leer_f( m_dia, mes, year, sig,dow);
leer_h( hora, min, seg );
switch (dow)
{
case 1:printf(lcd_putc,"\f SUN"); break;
case 2: printf(lcd_putc,"\f MON"); break;
case 3: printf(lcd_putc,"\f TUE"); break;
case 4: printf(lcd_putc,"\f WED"); break;
case 5: printf(lcd_putc,"\f THU"); break;
case 6: printf(lcd_putc,"\f FRI"); break;
case 7: printf(lcd_putc,"\f SAT"); break;
}
printf(lcd_putc," %2X/%2X/20%2X\",m_dia,mes,year);
printf(lcd_putc,"\n %2X:%2X:%",hora,min,seg);
delay_ms(800);
}
}

[rwyoung]

Spotted several issues.

1) Why do you keep calling enable_interrupts() inside your main's while(1) loop? Call these once before the while loop. The compiler generates the necessary code for entering and exiting the ISR to disable/re-enable interrupts.

2) DON'T do so much in your receive character interrupt. Interrupts should be very short, quick routines. Calling out to other functions, calling delay_ms().

3) When you leave your interrupt don't need to be disabling the interrupts. It makes no sense. See #1.

4) The "return" keyword is not necessary at the end of your uart receive ISR.

5) Your statment char c[] at the beginning of your program isn't allocating more than one byte for that array. Later in your ISR when you are indexing that array you are GUARANTEED to be stepping on other data. Not only did you not allocate memory for the array (so the compiler knows where to put other variables in RAM) you aren't testing the index variable "i" for boundary conditions.

6) USE THE "CODE" BUTTON. This preserves the formating of your code when posting. Just pasting it into your post, you loose the leading spaces/tabs on each line. Makes it much harder to read.
_________________
Rob Young
The Screw-Up Fairy may just visit you but he has crashed on my couch for the last month!

[JEliecer]

This is my new code:

[Darren Rook]

[JEliecer]

Thanks boys. Now, I have a routine for receive the characters from the rs232.

But now, I need to convert streams of numbers to whole numbers of 8 bits.

As I can record the data received in a variable, to transform it later into integers or long integers numbers....????
_________________
Jorge Eliécer Castro

"THE UNIVERSE FOREVER CONSPIRES SO THAT OUR DESIRES ARE WILL BE REALITY"

"EL UNIVERSO SIEMPRE CONSPIRA PARA QUE NUESTROS DESEOS SE HAGAN REALIDAD"

[Darren Rook]

Yes, look at atoi()

[JEliecer]

I renewed my code in this way:

[Mark]

Um, atoi() converts a piece of text to a number. You usually write text to displays otherwise you might not see it. Also, atoi() takes a pointer to a null terminated string. You are passing it a char which is incorrect. I think what you probably want to do it receive the chars into an array and then convert that array to an integer.

[DragonPIC]

[JEliecer]

This is a new code....

[Mark]

So you convert it from a string, to a number, and then back to a string? Kind of inefficient don't you think.

[JEliecer]

Yes, I want to do receive the chars into an array and then convert that array to an integer.

The string only have numbers.

But I can't do it. How can I do...???

Please help me boys.
_________________
Jorge Eliécer Castro

"THE UNIVERSE FOREVER CONSPIRES SO THAT OUR DESIRES ARE WILL BE REALITY"

"EL UNIVERSO SIEMPRE CONSPIRA PARA QUE NUESTROS DESEOS SE HAGAN REALIDAD"

[Mark]

As we "boys" have told you, use the atoi() function on the array of chars! Don't do it on every character, do it on the whole string. Clear as mudd yet?

[DragonPIC]

[JEliecer]

Hi,

I need your help again....

I wrote the code with yours indications, but it doesn't still work correctly...

I no know where I should define the char C[4]