ICD-U40 and PIC18F452 Development Kit

[Guest]

thanks for all the info and help. I will give it all a try and let you know how it comes out. I suspect that most of the problem has been with the CCS development board as it's not fully playing with the B port the way I want, or maybe I'm not doing what it thinks I should.

dave.

[Iloveoakdave]

Finally got it working via the ICD2 and Picdem 2 plus. Thanks for the help. Now I can start having some fun. Do you know if anybody has hooked the CCS ICD-U40 to the Picdem 2 plus board and had them working together. That would give another option for development and debugging.

Thanks.

dave

[kkkelis]

Hi
I am having trouble using this keypad driver with port C. What i did i just renamed the pin declarations from port B to port C. However when i ran the program , the LCD fills up with characters and numbers without pushing a button. Can someone give me a tip?

Thanks

[PCM programmer]

[kkelis]

Thanks for the tip-Fortunately i figured that out my self.
I am trying to make an 8x8 scan driver.What i tried to do is to modify the code posted earlier.
This is what i did:


//Keypad connection:
#define row0 PIN_B0
#define row1 PIN_B1
#define row2 PIN_B2
#define row3 PIN_B3
#define row4 PIN_B4
#define row5 PIN_B5
#define row6 PIN_B6
#define row7 PIN_B7

#define col0 PIN_C0
#define col1 PIN_C1
#define col2 PIN_C2
#define col3 PIN_C3
#define col4 PIN_C4
#define col5 PIN_C5
#define col6 PIN_C6
#define col7 PIN_C7


// Keypad layout:
char const KEYS[8][8] =
{{'1','2','3','4','5','6','7','8'},
{'9','10','11','12','13','14','15','16'},
{'17','18','19','20','21','22','23','24'},
{'25','26','27','28','29','30','31','32'},
{'33','34','35','36','37','38','39','40'},
{'41','42','43','44','45','46','47','48'},
{'49','50','51','52','53','54','55','56'},
{'57','58','59','60','61','62','63','64'}};


#define KBD_DEBOUNCE_FACTOR 33 // Set this number to apx n/333 where
// n is the number of times you expect
// to call kbd_getc each second

void kbd_init()
{
//set_tris_b(0xF0);
//output_b(0xF0);
port_b_pullups(true);
}

short int ALL_ROWS (void)
{
if(input (row0) & input (row1) & input (row2) & input (row3) & input (row4)
& input (row5) & input (row6) & input (row7))
return (0);
else
return (1);
}



char kbd_getc()
{
static byte kbd_call_count;
static short int kbd_down;
static char last_key;
static byte col;

byte kchar;
byte row;

kchar='\0';

if(++kbd_call_count>KBD_DEBOUNCE_FACTOR)
{
switch (col)
{
case 0:
output_low(col0);
output_high(col1);
output_high(col2);
output_high(col3);
output_high(col4);
output_high(col5);
output_high(col6);
output_high(col7);
break;

case 1:
output_high(col0);
output_low(col1);
output_high(col2);
output_high(col3);
output_high(col4);
output_high(col5);
output_high(col6);
output_high(col7);

break;

case 2:
output_high(col0);
output_high(col1);
output_low(col2);
output_high(col3);
output_high(col4);
output_high(col5);
output_high(col6);
output_high(col7);
break;

case 3:
output_high(col0);
output_high(col1);
output_high(col2);
output_low(col3);
output_high(col4);
output_high(col5);
output_high(col6);
output_high(col7);
break;

case 4:
output_high(col0);
output_high(col1);
output_high(col2);
output_high(col3);
output_low(col4);
output_high(col5);
output_high(col6);
output_high(col7);
break;

case 5:
output_high(col0);
output_high(col1);
output_high(col2);
output_high(col3);
output_high(col4);
output_low(col5);
output_high(col6);
output_high(col7);
break;

case 6:
output_high(col0);
output_high(col1);
output_high(col2);
output_high(col3);
output_high(col4);
output_high(col5);
output_low(col6);
output_high(col7);
break;

case 7:
output_high(col0);
output_high(col1);
output_high(col2);
output_high(col3);
output_high(col4);
output_high(col5);
output_high(col6);
output_low(col7);
break;
}

if(kbd_down)
{
if(!ALL_ROWS())
{
kbd_down=false;
kchar=last_key;
last_key='\0';
}
}
else
{
if(ALL_ROWS())
{
if(!input (row0))
row=0;
else if(!input (row1))
row=1;
else if(!input (row2))
row=2;
else if(!input (row3))
row=3;
else if(!input (row4))
row=4;
else if(!input (row5))
row=5;
else if(!input (row6))
row=6;
else if(!input (row7))
row=7;

last_key =KEYS[row][col];
kbd_down = true;
}
else
{
++col;
if(col==8)
col=0;
}
}
kbd_call_count=0;
}
return(kchar);
}


Unfortunately I am getting errors related with the Character constant constructed incorrectly??? I dont understand why this is happening

[PCM programmer]

You mean you're getting error messages during compilation ?
Post your compiler version and the error message, and tell us
the line of code that's causing the error.

[kkelis]

Yes i am getting error messages during compilation. I am Using ccs PCWH vesion 3.207 and MPLAB IDE 7.41

The lines that are causing the errors are those with // at the end:
char const KEYS[8][8] =
{{'1','2','3','4','5','6','7','8'},
{'9','10','11','12','13','14','15','16'}, // Line 26
{'17','18','19','20','21','22','23','24'}, // Line 27
{'25','26','27','28','29','30','31','32'}, // Line 28
{'33','34','35','36','37','38','39','40'}, // Line 29
{'41','42','43','44','45','46','47','48'}, // Line 30
{'49','50','51','52','53','54','55','56'}, // Line 31
{'57','58','59','60','61','62','63','64'}};


Here are some error messeges i get:
*** Error 5 "F:\Documents and Settings\Alexandros\Desktop\c++ PIC\18f452\keyboard and lcd\8x8kbd.c" Line 26(7,9): Character constant constructed incorrectly
*** Error 79 "F:\Documents and Settings\Alexandros\Desktop\c++ PIC\18f452\keyboard and lcd\8x8kbd.c" Line 26(23,25): Expect }
*** Error 43 "F:\Documents and Settings\Alexandros\Desktop\c++ PIC\18f452\keyboard and lcd\8x8kbd.c" Line 26(28,30): Expecting a declaration
*** Error 43 "F:\Documents and Settings\Alexandros\Desktop\c++ PIC\18f452\keyboard and lcd\8x8kbd.c" Line 26(30,33): Expecting a declaration
*** Error 43 "F:\Documents and Settings\Alexandros\Desktop\c++ PIC\18f452\keyboard and lcd\8x8kbd.c" Line 26(33,35): Expecting a declaration
*** Error 43 "F:\Documents and Settings\Alexandros\Desktop\c++ PIC\18f452\keyboard and lcd\8x8kbd.c" Line 26(35,38): Expecting a declaration
*** Error 43 "F:\Documents and Settings\Alexandros\Desktop\c++ PIC\18f452\keyboard and lcd\8x8kbd.c" Line 26(38,40): Expecting a declaration
*** Error 5 "F:\Documents and Settings\Alexandros\Desktop\c++ PIC\18f452\keyboard and lcd\8x8kbd.c" Line 26(40,42): Character constant constructed incorrectly
*** Error 43 "F:\Documents and Settings\Alexandros\Desktop\c++ PIC\18f452\keyboard and lcd\8x8kbd.c" Line 26(42,43): Expecting a declaration
*** Error 43 "F:\Documents and Settings\Alexandros\Desktop\c++ PIC\18f452\keyboard and lcd\8x8kbd.c" Line 27(2,3): Expecting a declaration
*** Error 5 "F:\Documents and Settings\Alexandros\Desktop\c++ PIC\18f452\keyboard and lcd\8x8kbd.c" Line 27(3,5): Character constant constructed incorrectly
*** Error 43 "F:\Documents and Settings\Alexandros\Desktop\c++ PIC\18f452\keyboard and lcd\8x8kbd.c" Line 27(5,6): Expecting a declaration
*** Error 43 "F:\Documents and Settings\Alexandros\Desktop\c++ PIC\18f452\keyboard and lcd\8x8kbd.c" Line 27(6,9): Expecting a declaration
*** Error 43 "F:\Documents and Settings\Alexandros\Desktop\c++ PIC\18f452\keyboard and lcd\8x8kbd.c" Line 27(9,11): Expecting a declaration
*** Error 43 "F:\Documents and Settings\Alexandros\Desktop\c++ PIC\18f452\keyboard and lcd\8x8kbd.c" Line 27(11,14): Expecting a declaration
*** Error 43 "F:\Documents and Settings\Alexandros\Desktop\c++ PIC\18f452\keyboard and lcd\8x8kbd.c" Line 27(14,16): Expecting a declaration
*** Error 43 "F:\Documents and Settings\Alexandros\Desktop\c++ PIC\18f452\keyboard and lcd\8x8kbd.c" Line 27(16,19): Expecting a declaration
*** Error 43 "F:\Documents and Settings\Alexandros\Desktop\c++ PIC\18f452\keyboard and lcd\8x8kbd.c" Line 27(19,21): Expecting a declaration
*** Error 43 "F:\Documents and Settings\Alexandros\Desktop\c++ PIC\18f452\keyboard and lcd\8x8kbd.c" Line 27(21,24): Expecting a declaration
*** Error 43 "F:\Documents and Settings\Alexandros\Desktop\c++ PIC\18f452\keyboard and lcd\8x8kbd.c" Line 27(24,26): Expecting a declaration
*** Error 43 "F:\Documents and Settings\Alexandros\Desktop\c++ PIC\18f452\keyboard and lcd\8x8kbd.c" Line 27(26,29): Expecting a declaration
*** Error 43 "F:\Documents and Settings\Alexandros\Desktop\c++ PIC\18f452\keyboard and lcd\8x8kbd.c" Line 27(29,31): Expecting a declaration
*** Error 43 "F:\Documents and Settings\Alexandros\Desktop\c++ PIC\18f452\keyboard and lcd\8x8kbd.c" Line 27(31,34): Expecting a declaration
*** Error 43 "F:\Documents and Settings\Alexandros\Desktop\c++ PIC\18f452\keyboard and lcd\8x8kbd.c" Line 27(34,36): Expecting a declaration
*** Error 43 "F:\Documents and Settings\Alexandros\Desktop\c++ PIC\18f452\keyboard and lcd\8x8kbd.c" Line 27(36,39): Expecting a declaration
*** Error 43 "F:\Documents and Settings\Alexandros\Desktop\c++ PIC\18f452\keyboard and lcd\8x8kbd.c" Line 27(39,41): Expecting a declaration
*** Error 5 "F:\Documents and Settings\Alexandros\Desktop\c++ PIC\18f452\keyboard and lcd\8x8kbd.c" Line 27(41,43): Character constant constructed incorrectly
*** Error 43 "F:\Documents and Settings\Alexandros\Desktop\c++ PIC\18f452\keyboard and lcd\8x8kbd.c" Line 27(43,44): Expecting a declaration

[Ttelmah]

I.m not suprised it is complaining. Your constants _are_ constructed incorrectly...

'3', is code to replace _one_ character, with it's ASCII code.
0x33, is the same code declared as a hexadecimal number.
51, is the same code declared as a decimal number.

'51', means nothing....

Best Wishes

[edp2009]

Hello,

I have tried to compile the code posted by PCM Programmer to no success.

I am trying to make keypad work with LCD. I have successfully made the flex_LCD driver work for me.

Here is KBD.c code (I use PORTE on PIC24H):

[PCM programmer]

That code is written for 18F-series PICs and below.

You need to download the PCD manual and look at the functions that
CCS uses for the 24-series PICs. This is the function they use for pullups:

[edp2009]

[edp2009]

[PCM programmer]

[edp2009]

[Razo_guest]

Not on my own machine and need to dig out my password so posting as a guest

Ok so I've used this driver before and wanted to use it again on my new project. This time I changed the controller, last controller was a PIC16f876a and new controller is a PIC16f887 because I've found there are easier to get as 1) they are still in production :P 2) they are cheaper.
But this driver was giving me a massive headache. The problem was with the pullups. I changed port_b_pullups(true); to port_b_pullups(0b00001111); and my headache went away. A nice facepalm there. I spent a while wondering why my keypad was going mental.

Thanks again for a nice driver.