breaking up a char array

[Christian]

Hello, I have been having alot of trouble breaking up a char array into component parts, for example my input to a pic is of the form "X:10;Y:10;" (w/o the quotations), however whenever i use the tokenizer i get garbage values, my code is below

------------------------------------------------------------------------------------

#include <18F458.h> //device
#device ICD=TRUE //allow for debugging with icd-u40
#device adc=10
#use delay(clock=40000000) //clock speed
#fuses NOWDT,HS
#use rs232(baud=9600,parity=N,xmit=PIN_C6,rcv=PIN_C7,stream=pc)
#use rs232(DEBUGGER)

#include <math.h>
#include <string.h>
#include <input.c>
#include <stdlib.h>

char Xval, Yval, ptr,str1,str2,str3,str4,str5,str6;
char delim[];
char commandstring[1], xNum[1], yNum[1];
Int index,indexx, check, rightcontent,error;
int16 xcoord=0, ycoord=0, sumcheck=0,sum=0,su=0;
int sum_check[];
char Checksum[3];
char *rxbuff;

void getCoords()
{
rxbuff=commandstring;
strcpy(delim,":;");
str1 = strtok(ptr,delim);
str2 = strtok(0,delim);
str3 = strtok(0,delim);
str4 = strtok(0,delim);

}

#int_RDA
void RDA_isr()
{
fgets(commandstring, pc);
//printf("%s\n", commandstring); //prints to interface
puts(commandstring); //prints to debugger monitor
getCoords();
}

void main()
{
enable_interrupts(INT_RDA);
enable_interrupts(GLOBAL);

while(1)
{

}
}

------------------------------------------------------------------------------------

what am i doing wrong?

[PCM programmer]

There are several things about your program that could be improved.
For example, you're not using #INT_RDA in the proper way. There is
also no reason to use interrupts in your current program.

To answer your question about strtok():
The CCS manual has a good example of how use strtok().
I made it into a test program, as shown below, and it
displays the following output:

[Christian]

thank you programmer for ur post, however i have used the tokenizer sucessful in a program similar to urs above, but i cant get it work whenever i'm trying to tokenize an input from a pc, i get garbage.

[PCM programmer]

OK, I took a closer look at your program in that area, and there are
several things wrong with it. The major thing is that your input
array is defined with a length = 1 byte. There's no room in it
to store your input string. You need to define a larger array.

There are a few other things wrong with your program.
You're using HS mode in your #fuses, but you have 40 MHz
specified in #use delay(). That's not right. You should
have NOLVP specified in your #fuses, unless you're using
low voltage programming (which is rare).

I think you have the demo. Maybe you're just using the MPLAB
simulator. Then these fuse settings don't matter. So I won't
say any more about them.

Here is a very simple test program which just gets a string
from your terminal program, and then displays it when
you press the Enter key on your PC.

[Christian]

hey programmer, not intending to be bashful but i have tried setting commandstring[30], but the code just wont work, and ur right i am using the hyperterminal, but i cant tokenize my inputs, does your code do this?
Thanks

[Christian]

problem solved

"You need to define a larger array"

thanks for that tip