Problem with driver "can-18xxx8.c"

[Uwe Koch]

Hello together,

I think there is a mistake inside CCS-Can-driver
"can-18xxx8.c". In the function to get the received ID
can_get_ID(...) a problem occurs if extended ID's were used.

The line

ret|=((int32)*ptr & 0xE0) << 18;

try to get the Bits 7..5 of RxBnSIDL and clears Bit4..0.
Up to this point all is OK.

Then these 3-Bits "should be" shifted to Bit 18..20 (16 extended-Bits
+ 2 extended-bits -> 0..17).

But they will be shifted to Bit 23..25 !!!
My suggestion:

ret|=((int32)*ptr & 0xE0) << 13;

Perhaps someone of CCS will take this.
By the way: Is there someone who has changed this driver
for PIC18F6680 (more filters...) ?

Kind regards
Uwe Koch




int32 can_get_id(int * addr, int1 ext) {
int32 ret;
int * ptr;

ret=0;
ptr=addr;

if (ext) {
ret=*ptr; //eidl

ptr--; //eidh
ret|=((int32)*ptr << 8);

ptr--; //sidl
ret|=((int32)*ptr & 0x03) << 16;
ret|=((int32)*ptr & 0xE0) << 13;
// ret|=((int32)*ptr & 0xE0) << 18; CCS-Fehler, die 3-Bits werden zu weit geschoben. Ich vermute die haben gedacht sie würden rechtsbündig im Register stehen(Bit0..2), dann wäre es OK.

ptr--; //sidh
ret|=((int32)*ptr << 21);

[PCM programmer]