Problem when using both external interrupt with low voltage

tienchuan · Joined: 25 Aug 2009 Posts: 175

Hi everybody.
I'm have problems when using both external interrupt with high-low voltage interrupts.
In my project, I used: int_ext0, int_ext1, int_rb and int_lowvolt of PIC18F4680, CCSC complier ver 5.021.
The trouble occurs when the circuit has an interrupt on int_ext1 pin, my program go to int_ext1 and int_lowvolt, the right is only run to int_ext1.
I referenced some topic in site but it not help me to solve this problem.
Because the code is long, so that i cutout some body of my program.

- config fuse and lib:

Ttelmah · Joined: 11 Mar 2010 Posts: 19515

The core reason is the simple one. Using a delay in the ISR. Treat this as if it carries a risk of ebola....

The key point is that ISR handlers should be _quick_. If you want a delay, then set a flag, and use a timer to give the delay.

A search here will find this repeated again and again. In fact if you search for the keyword 'mantra', I know you will find several posts.

You may get an answer then saying 'use high priority interrupts', but this won't work in this case, since INT_EXT, is always high priority if this is done.

Have a nice little 'tick' interrupt at something like 50mSec, and use this to provide your delays.

As it stands, if pin B1 is low, it'll stay in this ISR for ever.
_All_ your interrupts display similar versions of bad programming.

Consider a completely different approach. Have a tick interrupt as already mentioned, and have this check all the pins, and move through a state machine to give all the functions required. Advance the counter for delays, and the state for different pin patterns, and immediately exit.

tienchuan · Joined: 25 Aug 2009 Posts: 175

Thanks u.
I've modified all interrupt program by remove delay_ms() function and replace by loop delay.
I don't think i make a errors between int_ext1 with int_lowvolt.
I afraid CCS have a errors when compiling?
_________________
Begin Begin Begin !!!

Ttelmah · Joined: 11 Mar 2010 Posts: 19515

a 'loop delay', is just as bad if it is inside the interrupt.

The point is you _must_ get out of the interrupt handler ASAP.

As I said, use a single tick interrupt, and sample your pins in this. Whhen you want delays set a counter, and immediately exit. Next time the timer ticks, decrement the counter and exit.

Mike Walne · Joined: 19 Feb 2004 Posts: 1785 Location: Boston Spa UK

If you are convinced it's a CCS problem, write a short, complete, compilable program which proves the point.

I took one look at the length of your code and decided to ignore it.

Mike

temtronic · Posted: Wed Sep 03, 2014 10:35 am

also

you CANNOT write to the eeprom inside any ISR !! That too is very.very bad coding.NO delays( and writing to the eeprom is a HUGE delay...) are acceptable inside any ISR.

Simply set a 'flag' and get out ASAP.
within 'main()' do code based on the 'flags' set within the ISRs.

hth
jay

Ttelmah · Joined: 11 Mar 2010 Posts: 19515

Disagree just fractionally.

Power failure, is the _one_ interrupt where you can/do write to EEPROM. However you also need to work out how you are going to recover if the power goes back on, and the 'hold up' time of your supply relative to the write time.

The big problem before doing this though, is that it's never going to get to the power fail interrupt, since it is often sitting for ages in other (unnecessary) interrupts.....

tienchuan · Joined: 25 Aug 2009 Posts: 175

Thanks you so much.
I think I will edit my program as all our's advices, can be as follows:
- write a delay function using "for" loop.
- change delay function of CCSC by my delay function in ISR program.
- move ISR program to main loop program by check flag interrupts.
- repair ISR ext interrupts.
The first, I write a delay function using for loop to create a delay 10ms, but real it's seem longer. I can't calculate exact time delay creat in MPLAB, so I used help in CCSC and saw it take 0.4us with plus operation, with loop 25000 times, it makes 10ms.

Ttelmah · Joined: 11 Mar 2010 Posts: 19515

You are just ignoring the key point:

"The point is you _must_ get out of the interrupt handler ASAP. "

Using your delay, instead of the CCS delay, makes no difference. You are still delaying in the ISR.
This is equivalent to hitting yourself on the head with a sledgehammer. Not likely to lead to working code.

If you want something to happen an time 'after' an edge is seen, program a timer with the required timeout, and leave the interrupt handler immediately. Then when this timer triggers and interrupts, do the other half of your job.

However the whole thing is much simpler if you just have a 'tick' interrupt, and do the jobs needing timing in this. The approach is over complicated, and is causing your problems.