led Blink

[cchechio]

I am using mplab and ccs compiler.

i am testing my pic 16f88 and i write a simple led blinking.

here there is the code:

#include <16F88.h>
void main(void) {

#byte OSCCON = 0x60
setup_adc(ADC_OFF);
set_tris_b( 0x00 );

#use delay(clock=4000000)
while(1) {
OUTPUT_HIGH(PIN_B5);
DELAY_MS(500);
OUTPUT_LOW(PIN_B5);
DELAY_MS(500);
}
}

i have compiled this code and all ok.

after i have selected the programmer picKit2
and then i program the target device.

but my led is off.

why ?

Can you help me ?

[FvM]

A PIC16F88 has no OSCCON register. Clock operation depends on fuses settings, that may be wrong in your code, if present at all. You should show the complete code.

[cchechio]

PIC16F88 have OSCCON register.

[dyeatman]

I am surprised it compiled. You are not constructing your program
properly. Your pre-processor statements should be outside the Main code
as shown in the below example.

The below uses the internal oscillator at 4MHZ. I put
in the fuse statement and the setup_oscillator line rather than direct
register setting. Let the compiler do the work....

[cchechio]

Ok.

but why my led is off.

i have compiled the code.

and click the button "Program the target device"

Where is my error ?

[dyeatman]

The code is simple and should run with no problems if your hardware is good. I would suspect how the LED is connected to the PIC.

A few questions:

How is the LED connected to the PIC? Is it from the PIC to ground or to VCC? What is the value of the series resistor?

[FvM]

[cchechio]

Here, there are how I have connected PIC16F88 :

[FvM]

The hardware looks O.K., so a configuration errors seems likely. You have no MCLR pull-up, it doesn't work e. g. with MCLR #fuse enabled. Unfortunately, you didn't yet show your configuration.

[cchechio]

i read the configuration from picKit 2 programmer:

my configuration is:
Device: PIC16F88
UserID: FF FF FF FF
Checksum 6E35
Configuration 3F70 0003

VDD Target:
O Check
X /MCLR


Program Memory
Enabled

EEPROM Data
Enabled

[FvM]

Seems O.K. except for MCLR connection. You need either a pullup or must disable MCLR function.