![](templates/subSilver/images/CCSLogo.jpg) |
![CCS C Software and Maintenance Offers](templates/subSilver/images/forumAd6.jpg) |
View previous topic :: View next topic |
Author |
Message |
tinley
Joined: 09 May 2006 Posts: 67
|
RS232 TX Buffer overrun??? |
Posted: Wed Nov 05, 2008 4:19 am |
|
|
I have checked all over the documentation and can't find an answer to this question: How does the compiler assign a buffer to RS232 TX? My application has a declared large input buffer and transmits large amounts of Data on an 18F2550. The pic halts, apparently because the TX buffer is using more ram than is available. I think I prove this by reducing the size of the input buffer/s, so allowing more space... but I require the biggest buffers I can get! And I want to understand fully when the pic might crash. The program is using USB and a bootloader and is complied with 4.081:
Code: | #fuses HSPLL,WDT64,NOWDT,NOPROTECT,NOLVP,NODEBUG,USBDIV,PLL5,CPUDIV1,VREGEN,NOXINST
#use delay(clock=48000000, restart_wdt)
#use rs232(baud=4800,parity=N,xmit=PIN_C6,rcv=PIN_C7,stream=hardUart,bits=8,errors)
#priority ext1,timer2
#define BUFFER_SIZE 300
char mainBuffer[BUFFER_SIZE];
char softBuffer[BUFFER_SIZE];
char usbBuffer[160];
#define txBuffer usbBuffer
while(true){
sprintf(txBuffer,"$IIVHW,,,%03lu,M,%01.2g,N,,",heading,speed);//example of type of data used
if(usb_cdc_connected())printf(usb_cdc_putc,txBuffer);
else printf(txBuffer);
} | Now when I try transmitting lots of data without USB connected, the pic halts, (or watchdog reset if enabled). If USB is connected, software runs without fault.
Please help?! |
|
![](templates/subSilver/images/spacer.gif) |
Ttelmah Guest
|
|
Posted: Wed Nov 05, 2008 5:42 am |
|
|
The compiler doesn't.
Transmission is unbuffered, excwet for the internal hardware buffering in the chip (two characters for most PICs).
Look at ex_stisr.c, for an example of buffered transmission, and the code needed to do this. As a 'comment' though, don't use 300 bytes with this code. Either switch to a binary size (64/128 bytes), or perform the buffer overflow test as:
Code: |
t_next_out=t_next_out+1;
if (t_next_out == T_BUFFER_SIZE) t_next_out=0;
|
As written by CCS, if you use a non binary buffer size, the compiler will perform a division in the interrupt routine, resulting almost certainly in interrupts being disabled in the main for divisons, and is a rather significant 'time' penalty.
Also, you will have to increase the sizes of the address variables to INT16, for a buffer over 256 bytes.
Best Wishes |
|
![](templates/subSilver/images/spacer.gif) |
tinley
Joined: 09 May 2006 Posts: 67
|
|
Posted: Wed Nov 05, 2008 6:31 am |
|
|
The problem seems to be caused by the complier sending data before the UART is ready to receive it. It is NOT caused by the way the buffers are used, as it happens by them simply being there.
This following workaround runs, so I am sorted, but is there a bug to be fixed??
printf(txBuffer);
delay_uS(1);
Note that delay_cycles( 200 ); does not work, even though it amounts to longer than 1uS.
Is this because delay_uS(1); becomes longer, (long enough), due to the UART TX interupts? |
|
![](templates/subSilver/images/spacer.gif) |
Wayne_
Joined: 10 Oct 2007 Posts: 681
|
|
Posted: Wed Nov 05, 2008 7:05 am |
|
|
"Now when I try transmitting lots of data without USB connected, the pic halts, (or watchdog reset if enabled). If USB is connected, software runs without fault. "
So this snippet of code you have posted does NOT fail, as it is not in my opinion sending lots of data.
Also, where is the USB code included ?
You are not using a tx interrupt somewhere are you ? |
|
![](templates/subSilver/images/spacer.gif) |
tinley
Joined: 09 May 2006 Posts: 67
|
|
Posted: Wed Nov 05, 2008 7:54 am |
|
|
This snippet DOES fail, because the data is being sent in a loop. This snippet does not crash the processor though... it just corrupts the data.
Is it possible that this data is actually corrupted by Hyperterminal?
I which case I've been led up the garden path and the bug is in the main program is elsewhere. The snippet was to proove the compiler, before spending more hours on my code!!!
I haven't shown the USB code, as the snippet fails with or without it.
No, I'm not using the tx int. I assume that CCS use this anyway.
In further answer to Ttelmah, I do not need or want a TX buffer, as the buffering is done on the 2 inputs.
Thank you for your help! |
|
![](templates/subSilver/images/spacer.gif) |
Wayne_
Joined: 10 Oct 2007 Posts: 681
|
|
Posted: Wed Nov 05, 2008 8:24 am |
|
|
You initially said the pic stops or if the WD is enabled it is reset.
Now you are saying the data that is shown on hyperterminal is corrupt!
There are no linefeeds or carrige returns "\r\n" being output which would mean the data is displayed on one line of hyperterminal, unless it is wrapping around. you are proberbly seeing the data overwrite itself on hyperterminal which is why it looks like it is getting corrupted.
if it fails without the USB code then remove the if statement and just output to hyperterminal!
I don't believe CCS uses the txint unless you use one of the libraries for buffered output (bputc). |
|
![](templates/subSilver/images/spacer.gif) |
tinley
Joined: 09 May 2006 Posts: 67
|
|
Posted: Wed Nov 05, 2008 9:05 am |
|
|
Thanks Wayne,
The bug in the main software is that it halts... but only if the buffers declared are large.
I tried to proove this was an overrun of the TX in some way with the examples given.
As you say, I expect the data to be displayed on one line, which it is. However, after some 5-10 secconds, the data becomes very corrupt. I don't know:
1. If this is Hyperterminal or the Pic
2. If this is causing the bigger program to crash.
Actually I did remove the if usb coonected else... it still produces garbage on hyperterminal.
The program is now running, but it still freezes if I use buffers bigger than about 275 bytes. The trouble is the bigger the buffers the more likely it freezes, so I don't know how big they can be for them to never freeze? They froze once in ten minutes at 275 bytes and 275 is barely big enough. |
|
![](templates/subSilver/images/spacer.gif) |
Wayne_
Joined: 10 Oct 2007 Posts: 681
|
|
Posted: Wed Nov 05, 2008 10:12 am |
|
|
When you build it what is the memory usage reported ? |
|
![](templates/subSilver/images/spacer.gif) |
tinley
Joined: 09 May 2006 Posts: 67
|
|
Posted: Wed Nov 05, 2008 10:20 am |
|
|
98-100%
Also, could you please clarify where I might find info in the binary buffer size... although this seems to make no difference in my application?
Cheers |
|
![](templates/subSilver/images/spacer.gif) |
|
|
You cannot post new topics in this forum You cannot reply to topics in this forum You cannot edit your posts in this forum You cannot delete your posts in this forum You cannot vote in polls in this forum
|
Powered by phpBB © 2001, 2005 phpBB Group
|