Question about LCD display (most likely to be interrupts)

[HWGonly1]

#include"flex_lcd.c"
int count=0;
int RunMilege=0;
int mode=0;
int flag=1;
unsigned long Price;
int hun;
int ten;
int one;
void price1()
{
int TotalPrice;
if(RunMilege<=2300)
TotalPrice=800;
if((RunMilege>2300)&&(RunMilege<=35000))
TotalPrice=800+(RunMilege-2300)*0.26;
if(RunMilege>35000)
TotalPrice=1112+(RunMilege-35000)*0.35;
Price=(unsigned long)(TotalPrice/100);
}
void end()
{
lcd_putc('\f');
putc('\n');
mode=0;
count=0;
RunMilege=0;
flag=0;
Price=0;
}
void arrive()
{
lcd_putc('\f');
lcd_putc('\n');
hun=Price/100;
ten=(Price-hun*100)/10;
one=Price-hun*100-ten*10;
if(hun!=0){lcd_putc(hun+0x30);lcd_putc(ten+0x30);lcd_putc(one+0x30);}
else if(ten!=0){lcd_putc(ten+0x30);lcd_putc(one+0x30);}
else{lcd_putc(one+0x30);}
//display"Price"
}
void vacant_car()
{
lcd_putc('\f');
lcd_putc('\n');
lcd_putc('V');
lcd_putc('a');
lcd_putc('c');
lcd_putc('a');
lcd_putc('n');
lcd_putc('t');
//Display"vacant"
}
void welcome()
{
lcd_putc('\f');
lcd_putc('\n');
lcd_putc('W');
lcd_putc('e');
lcd_putc('l');
lcd_putc('c');
lcd_putc('o');
lcd_putc('m');
lcd_putc('e');
//display“Welcome”
}
#int_ext
void breakloop()
{
flag=1;
mode=(mode+1)%3;
}
void carrying()
{
setup_timer_1(T1_EXTERNAL);
set_timer1(0);
while(flag==0){}
//count pulse of TMR1
}
void main()
{
lcd_init();
enable_interrupts(global);
ext_int_edge(H_TO_L);
enable_interrupts(int_ext);
while(1)
{
if(mode==0)
{
if(flag==1)
{
count=0;
vacant_car();
flag=0;
}
}
else if(mode==1)
{
if(flag==1)
{
welcome();
carrying();
clear_interrupt(int_ext);
flag=0;
}
}
else if(mode==2)
{
if(flag=1)
{
price1();
arrive();
flag=0;
}
}
else if(mode==3)
{
if(flag==0)
{
end();
flag=0;
}
}
}
}

[naughty_mark]

Hi HWGonly1

I am also a newbee or say a little old newbee with CCS compiler. Not sure for your question, but:

1. It is better you tell people what microcontroller you are using and what is the version of CCS you are using. Otherwise, people will be hard to help you.

2. Most of your function named by Chinese PIN YIN, it may doesn't make sense to English speaker who is most likely to help you here. I suggest you change that names for easily reading.

3. If possible, you may general describe what is your project doing, so others can easily check if there is any logic problem in your code. Sounds like a bus transport dispatch simulate project

At last, sorry for my poor English as well



Regards
Mark

[Ttelmah]

Some other comments:

1) Don't use float....
It is _not_ suitable for anything involving money. Use a scaled integer. So count in 'cents' in an int32. Problem is that floats have rounding errors, and you will end up with the wrong result long term....
Use cents, and hundredths of a mile (perhaps).

2) Use printf.
For instance your 'welcome' routine, can be done as:

printf(lcd_putc,"\f\nWelcome");

There is no point in the delay between the line feed and the text, the LCD driver will wait till the text can be displayed.
Also printf supports a 'scaled integer' format, that can display a 'cent' count as decimal dollars.

4) Add one delay before lcd_init.
Generally LCD's take quite a time to wake. Often at least half a second _later_ than the PIC. Hence you need to pause before starting.
5) Read the 'sticky' at the top of the forum about Proteus(Isis). Problem is that you can build circuits in Proteus that won't work when you make them for real (so the 'development' with it is wasted time), and perhaps worse, you can build designs in the real world that don't work in Proteus....

6) Initialise the interrupt with:

[HWGonly1]

Thank you very much, I know there are many disadvantage with my program.
I have correct them but it still doesn't change what LCD display.

LCD keep displaying "Vacant" whatever i do.....

I'll go try built it in real.

Please help me, experienced programmers

I'm just a poor student try to complete my work
[img]http://t1.qpic.cn/mblogpic/10494df6ccbb928d9e68/460[/img]

[Ttelmah]

Learn to use the code buttons

[HWGonly1]

Thank you very much for rewrite the code for me. However it's still troubling with just display "Vacant car".
Seems the #int_ext still don't work.
Do you have any idea,I'm sure my simulation circuit is right.

[Ttelmah]

As I said:

"Then the button input, and (possibly) the odometer pulse (if this is what it is), will need pull-up resistors."

A button on it's own, won't generate a signal the PIC can see.

[HWGonly1]

[HWGonly1]

[quote="HWGonly1"]

[Ttelmah]

Think.

You are programming the interrupt to trigger when the pin goes high to low.

The pin needs to be pulled _high_ when the button is not pressed, and then pulled _low_ by the button.

So the standard circuit is a resistor from the pin to Vdd, and then the button from the pin to Vss. This way, when the button is pressed, the pin goes low.

[temtronic]

also you'll probably need to add a small 'filter' cap across the switch contacts to minimize the 'bounce' or you'll get multiple inputs!

hth
jay

[PCM programmer]

This is a schematic of how you should connect the pushbutton, per
Ttelmah's description:

[HWGonly1]

[HWGonly1]

[HWGonly1]