Expecting function name! PIC16F877A speedometer

[vcdro]

i got this code of speedometer somewhere in the net and i already made some changes to it.. however i really can't figure out what's the problem, can you guys help me out with this?, also, i'm not that familiar with the language so please bear with me if i may look foolish with this... hehe thanks to those who will share their knowledge..

here's the code:

#include <16F877A.h>
#device adc=8
#use delay(clock=4000000)
#fuses XT, BROWNOUT,NOWDT
#include <lcdx.c>
float rpm=0,kmph=0;
int16 count=0,rpmi;
int timer_co=0x00;
unsigned char lcd_buffer[17];


#int_EXT
void EXT_isr(void)
{
count=count+1;
}


#int_TIMER1
void TIMER1_isr(void)
{
timer_co=timer_co+1;
if(timer_co==15)
{
rpm=count*15; // calculating rpm
kmph=rpm*.06;
rpmi=rpm; count=0;
timer_co=0x00;
lcd_putc('\f');
sprintf(lcd_buffer,"%ld",rpmi);
lcd_puts(lcd_buffer,UL);
sprintf(lcd_buffer,"%f",kmph);
lcd_puts(lcd_buffer,UR);
sprintf(lcd_buffer,"rpm");
lcd_puts(lcd_buffer,LL);
sprintf(lcd_buffer,"Kmph");
lcd_puts(lcd_buffer,LR);
} >>>>> expecting function name appear here
}

[Ttelmah]

1) This is probably the best example of how _not_ to write an ISR I have seen for a while. Repeat this mantra fifty times, stick a bucket on your head, and repeat it again. _Interrupt handlers should be as short as possible_. _They should do just what the interrupt requires them to do, and nothing else_.
2) Look at the syntax of the lines in front of the error. Are you sending the right type of data to the functions?. Are the functions correctly written (you are not using the standard library, so we can't tell).

[vcdro]

actually, from the original code , it was only "EXT_isr and TIMER1_isr" not "void EXT_isr(void) etc." so i guess it's my mistake to put it that way.. i just did that because it had an error "function not void and does not return value" something like that so i assume i corrected that error by putting void on it..

anyway, do you have any idea where should I begin to fix these errors? Thank you for replying., highly appreciated..

[Gabriel]

that code you posted _without code buttons_ is incomplete...

you don't have a "main" function... i only see 2 ISRs and fuses...
I highly doubt it compiles...


looks like you are using the Flex driver... PCM has been kind enough to explain clearly how to use it... i don't see you even including the driver (PCMs or CCS)

EDIT: i found the driver declaration.... my bad.


you have not understood the point made by Ttelmah...
_keep your ISR short_ printing to terminals or to LCDs is _Very_time consuming...




but then again you don't have a main function... so... all of the above is pretty irrelevant...

G.
_________________
CCS PCM 5.078 & CCS PCH 5.093

[vcdro]

thank you Gabriel

i just put a main function before but it did not work either.. or maybe i just don't know where should i exactly put the main function on the code..

sorry for my stupidity, i hope you have more patience to answer my questions.. thank you again..

[Gabriel]

the "main" function:

Literally:

[ezflyr]

[vcdro]

That's what i did before and if i'd remember it right it had an error "a numeric expression must appear here"..

hmmm... maybe you're right about me starting with a blink program, i will consider that one... i just thought of knowing about this code because part of my project is about programming and i admit that i'm not that knowledgeably into that..

Thank you again Gabriel for your effort!

[vcdro]

ezflyr,

Thank you for the comment, i will consider your thoughts..

[Ttelmah]

If you look again at what he posts, he is using a non standard driver (not flex lcd, or the CCS supplied one), called 'lcdx.c'. This is including a puts declaration, which suggests it is for another C, since this is not needed in CCS (with it's ability to printf, to the LCD driver). Then he calls this with a series of values which he does not show the declarations for (UL, LL etc.). Almost certainly a syntax error in this code, hence my comment:

"Look at the syntax of the lines in front of the error. Are you sending the right type of data to the functions?. Are the functions correctly written (you are not using the standard library, so we can't tell).".

Best Wishes

[asmboy]

There is something missing from the ISR to make it a complete endeavor!!!

[Mike Walne]

I've kept out of this one so far.

At the risk of incurring the moderator's wrath, this is my advice.

1) Plagiarizing other's work is usually a waste of time.
2) Do some reading, 'C', CCS manual, PIC data sheets, forum guidelines.
3) Start from simple beginnings.
4) Try out some of the CCS examples, LED blink, UART, LCD, ISR etc.
5) Learn to drive the peripherals for yourself, one at a time.
6) Write your own code.
7) If (when) you get stuck, ask for help on a specific issue.
8) The relatively small number of guys who've contributed to this thread collectively have over a century's experience, don't antagonize or ignore them, treat them with respect.

Mike

EDIT
I don't personally know any of the other guys here, we live all over the globe.
We do occasionally have differences of opinion, but usually there's a concensus.
I've learnt that many of them have been in this game for decades, you can't put a price on their advice, yet they give it freely.