![](templates/subSilver/images/CCSLogo.jpg) |
![CCS C Software and Maintenance Offers](templates/subSilver/images/forumAd6.jpg) |
View previous topic :: View next topic |
Author |
Message |
aymanoo
Joined: 26 Aug 2011 Posts: 6
|
verifying an array? |
Posted: Mon Oct 03, 2011 1:02 pm |
|
|
Is the code correct in line 2?
Code: |
int8 password_array[8];
if (password_array=="12311111")
{
output_high(pin_c3);
delay_ms(30000);
}
else
output_high(pin_c4);
} |
This is part from a project that ask the user to enter the code through a keypad (i used flex_kbd). If the code correct the pin c3 goes high. _________________ AYMAN |
|
![](templates/subSilver/images/spacer.gif) |
ezflyr
Joined: 25 Oct 2010 Posts: 1019 Location: Tewksbury, MA
|
|
Posted: Mon Oct 03, 2011 1:18 pm |
|
|
Hi,
Give it a try, and I think you'll find it doesn't work. It may not even compile....
You'll need something like this:
Code: |
if (password_array[0] == '1' && password_array[1] == '2' && password_array[2] == '3') && ............)
|
John |
|
![](templates/subSilver/images/spacer.gif) |
FvM
Joined: 27 Aug 2008 Posts: 2337 Location: Germany
|
|
Posted: Mon Oct 03, 2011 1:27 pm |
|
|
You can use strcmp(), but than the array must include a terminating null and have the length increased by one character. |
|
![](templates/subSilver/images/spacer.gif) |
aymanoo
Joined: 26 Aug 2011 Posts: 6
|
thx it worked |
Posted: Tue Oct 04, 2011 10:13 am |
|
|
ezflyr wrote: | Hi,
Give it a try, and I think you'll find it doesn't work. It may not even compile....
You'll need something like this:
Code: |
if (password_array[0] == '1' && password_array[1] == '2' && password_array[2] == '3') && ............)
|
John |
_________________ AYMAN |
|
![](templates/subSilver/images/spacer.gif) |
RF_Developer
Joined: 07 Feb 2011 Posts: 839
|
|
Posted: Wed Oct 05, 2011 3:40 am |
|
|
There are other approaches to solve this problem, and problems like it.
This sort of thing is OK if its all the PIC is doing, i.e. in an exercise or a very simple widget. I say that as comparing an entered password against a single constant password hardwired into the code is very simple indeed, and almost useless in practical systems... except just possibly as a developer's backdoor. In most real systems you generally can't afford - space and money - to allocate one PIC to one function, so its going to have to do more than one thing, such as operate a lock, scan a keypad, multiplex a display AND communicate to a remote access control system all at the same time. In these sorts of systems a state machine approach is probably more useful.
I use this approach for all sorts of things including system state control and sequencing, numeric decoding and verification, button press detection/debouncing (including single/double click detection etc), comms protocol implementation and packet reading/decoding/verification.
In this instance consider your code running on a PIC that has a main loop running round and round continuously doing stuff is sequence - the standard main loop thing. You can't lock up other tasks while one bit delays, or waits for a button press, or a character to arrive on a serial port, or a message from CAN or whatever. All these things must run all the time without interfering with each other. State machines, one for each function that needs sequencing, all get called from the main loop. Other stuff runs too, like ADC measurements or checking input pins. The password input machine looks for a keypress, or serial input or whatever its input is, if it gets one it compares it to the relevant entry in the array, if good then it changes its state to look for the next keypress/character/whatever. If bad, it goes back to the idle state. Only once the machine has worked its way through all the entires one by one, can it enter the "release authorised" state and enable the lock. It starts a timer, either hardware or firmware derived from an interrupt routine, which will raise a flag in due course. When the flag is seen the lock is closed and the state machine goes back to idle to await the next time....
State machines are often introduced with the classic traffic light assignment, but there are many, many uses for them. They are a powerful tool in embedded systems.
RF Developer |
|
![](templates/subSilver/images/spacer.gif) |
|
|
You cannot post new topics in this forum You cannot reply to topics in this forum You cannot edit your posts in this forum You cannot delete your posts in this forum You cannot vote in polls in this forum
|
Powered by phpBB © 2001, 2005 phpBB Group
|