Interrupts disabled during call to prevent re-entrancy

[Milos]

Hello everybody i have a problem with my program the code goes like this:

#if defined(__PCH__)
#include <18F458.h>
#fuses HS,NOWDT,NOPROTECT,NOLVP
#use delay(clock=10000000)
#use rs232(baud=9600, xmit=PIN_C6, rcv=PIN_C7)
#endif

#include <LCD2.C>

#define INTS_PER_SECOND 152 // (10000000/(256*256))



BYTE int_count; // Number of interrupts left before a second has elapsed

void lcd_dec2str3(unsigned long x) //decimala u string
{
unsigned long y;
if (x<1000)
{
y=x/100;lcd_putc(y+0x30);x-=(y*100); // stotice
y=x/10;lcd_putc(y+0x30);x-=(y*10); // desetice
lcd_putc(x+0x30); // jedinice
}
else lcd_putc("Greska");
}

#INT_RTCC
void brojac_isr()

{
delay_ms(1000); // every second

lcd_gotoxy(0, 1);
lcd_putc(" INTERRUPT !!! ");
lcd_gotoxy(0, 0); // pozicioniraj se u prva kolona - drugi red
lcd_putc(" "); // ispisi na LCD

int_count=INTS_PER_SECOND;
}

void main()

{

long counter;
lcd_init();

int_count=INTS_PER_SECOND;
set_timer0(152);
setup_counters( RTCC_INTERNAL,RTCC_DIV_256 | RTCC_8_BIT);
enable_interrupts(INT_RTCC);
enable_interrupts(GLOBAL);

printf("\n\n");

counter=0; // reset the counter

do

{
lcd_gotoxy(0, 1); // pozicioniraj se u prva kolona - drugi red
lcd_putc(" "); // ispisi na LCD
lcd_gotoxy(0, 0); // prva kolona drugi red
lcd_putc("Brojac: ");
lcd_gotoxy(10, 0); // 10ta kolona drugi red
lcd_dec2str3(counter);
counter++; // display count value and increment
delay_ms(1000); // every second
} while (TRUE);


}


The problem is that i get 5 warning massages Interrupts disabled during call to prevent re-entrancy.
The program is working counter counts on every interrupt change but in 1 moment i am getting both massages on LCD display "INTERRUPT !!!" and "Brojac XXX".
Program should do next show massage in interrupt for 1 second "INTERRUPT !!!" than increment counter and show "Brojac xxx" and so on.

Well it shows "Brojac xxx" for 1 second , but interrupt is lasting like 4 seconds and i dont know why... I wanted it to show 1 sec "Brojac xxx" , 1 sec "INTERRUPT !!!".

And after counter gets to 5-6 changes i am getting both massages on the LCD screen or i get part of 1st and part of 2nd massages.

Well now u can try to compile program but i have changed #include<LCD2.c> coz i have different pins for LCD.

Pls try to explain me why tnx and best wishes Milos.

[Matro]

[Matro]

And stop working with delay_ms function. This function is just time wasting during which the MCU does nothing.
Your ISR should look like that :

[Matro]

Below a proposal :

[Milos]

tnx Matro.

i ll try to compile the way u have done it.

i ll try to run program and see what went wrong with x<1000 and i ll post u code i think it counts to 1000 without problem.

[rnielsen]

When working with interrupts, placing printf(), putc() or puts() statements inside of them is highly discouraged. Interrupts should be very short. Get in, do something quick and then get out. Print statements generate loads of code and will bog down your program. If you're just printing something to help debug then I could understand.

You would, normally, set a flag and then evaluate that flag somewhere in your main() section.

Ronald

[RLScott]

[KU5D]

Things like printf() and worse yet delays are a sin in an ISR. For a convincing demonstration, see what a delay_ms(1) does to this? The delay_ms() masks everything, and note how the RDA interrupt is stacked up until the delay expires. This is a screenshot from a DV-100 that is wired to I/O pins that I use as test points in my interrupt service routines. This is the perfect way to test your ISRs. Toggle a pin and use a 'scope or similar tool to see if they are working. It takes almost zero time.


_________________
Confidence is the feeling you have right before you fully understand the situation...