Broken #INT_RDA in PCH 3.170

[NikkiC]

PCH 3.170, PIC18F452

Do I need glasses?

What exactly is the point of sending out zeros ad infinitum in this interrupt routine when the actual C code is supposed to read from the RCREG regsiter? Hmmmmmm.

.................... #INT_RDA
.................... rda()
.................... {
021E: NOP(FFFF)
.................... chr=getc();
0220: MOVF 00,W
0222: BTFSS F9E.4
0224: GOTO 0222
0228: MOVWF FAD
022A: MOVLB 3
022C: MOVWF x5D
.................... putc('1');
022E: MOVLW 31
0230: BTFSS F9E.4
0232: GOTO 0230
0236: MOVWF FAD
.................... }
....................
0238: BCF F9E.5
023A: MOVLB 0
023C: GOTO 006E

Compiled again but within different C code. Looks a bit better. I'll have to backtrack to a better compiler version.


.................... #INT_RDA
.................... rda()
.................... {
*
0140: NOP(FFFF)
.................... chr=getc();
0142: BTFSS F9E.5
0144: GOTO 0142
0148: MOVF FAE,W
014A: MOVWF 48
.................... putc('1');
014C: MOVLW 31
014E: MOVLB 2
0150: MOVWF xE2
0152: MOVLB 0
0154: CALL 0118
.................... }
....................
....................
0158: BCF F9E.5
015A: GOTO 0056

[NikkiC]

Yes, I think this does the trick:

#byte RCREG = 0xFAE

#INT_RDA
rda()
{
chr=RCREG;
}

Nikki